Sorry it took me so long to get to this! It's been a hectic time of year. Regardless, thanks for pitching in on this issue. I have one minor question there then the code looks good. Could you throw in a test for it as well? Then I think it's all set.

No problem at all! Open Source should be fun so please don't feel pressured :)

I tweaked the existing test to make it fail without the fix and added a new test to test the loop counter adjustment in app/gosqs/gosqs_test.go. I'm not sure what your preference is in tests in terms of duplicate code v.s. maintaining abstractions in the test files. If you prefer me to move some shared code to a helper just let me know.

@Thomasvdam This looks awesome, thanks for sticking with it for so long! This looks great to me! Though I see that I probably burned you by moving some things around, would you mind rebasing? I assume that would fix your tests there.

Otherwise, I'm ready to do the merge deed! Are you anxiously awaited this? I had to get some fixes into the 0.5.1 release, which just went out, so I missed sneaking you into that, but I could make this 0.5.2 if you're needing it, like, yesterday?

No rush from my end. I'm using my fork so please release at your own pace. I'll try the rebase now

Ah I didn't know about the --race flag, I'll have to look into that!

Ah I didn't know about the --race flag, I'll have to look into that!

Ah yeah, that gets me too. Let me know if you get stuck after trying it with that and I'll have a look and see if I can shake anything loose. Thank you!

I think this should get the tests to pass reliably. It feels a little hacky though, if you have pointers on a proper way to do this I'd love to learn :)

@Thomasvdam Yeah, I think to rework it, which is worthy, would take some significant refactoring. What you've got is good, since we were never calling done before and therefor probably never shutting down out multiple goroutines. So thanks for taking care of that. Looks good to me, merging!